On Thu, Sep 03, 2020 at 11:05:36AM +0100, Paul Durrant wrote: > From: Paul Durrant <[email protected]> > > The manpage for 'xl' documents an option to force a block device to be > released even if the domain to which it is attached does not co-operate. > This option, however, is not implemented. This patch implements the option. > > NOTE: The documentation is also adjusted since the normal positioning of > options is before compulsory parameters. It is also noted that use of > the --force option may lead to a guest crash. > > Signed-off-by: Paul Durrant <[email protected]> > --- > Cc: Ian Jackson <[email protected]> > Cc: Wei Liu <[email protected]> > Cc: Anthony PERARD <[email protected]> > --- > docs/man/xl.1.pod.in | 4 ++-- > tools/xl/xl_block.c | 21 ++++++++++++++++----- > tools/xl/xl_cmdtable.c | 3 ++- > 3 files changed, 20 insertions(+), 8 deletions(-) > > diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in > index 52a47a6fbd..5f7d3a7134 100644 > --- a/docs/man/xl.1.pod.in > +++ b/docs/man/xl.1.pod.in > @@ -1389,7 +1389,7 @@ Note that only PV block devices are supported by > block-attach. > Requests to attach emulated devices (eg, vdev=hdc) will result in only > the PV view being available to the guest. > > -=item B<block-detach> I<domain-id> I<devid> [I<OPTIONS>] > +=item B<block-detach> [I<OPTIONS>] I<domain-id> I<devid> > > Detach a domain's virtual block device. I<devid> may be the symbolic > name or the numeric device id given to the device by domain 0. You > @@ -1406,7 +1406,7 @@ B<OPTIONS> > =item B<--force> > > If this parameter is specified the device will be forcefully detached, which > -may cause IO errors in the domain. > +may cause IO errors in the domain and possibly a guest crash
Missing "." at the end. This can be fixed while committing. Acked-by: Wei Liu <[email protected]>
