> On 4 Sep 2020, at 11:20, Jan Beulich <[email protected]> wrote: > > On 04.09.2020 11:54, George Dunlap wrote: >> At the community call last month as well as this, we discussed whether to >> continue the “Gitlab experiment”. It was generally agreed that reviewing >> Juergen’s long series was fairly sub-optimal, and that email was more suited >> to that sort of series. >> >> That said, there was general agreement that requiring all patches to go >> through email was going to limit contribution, particularly of one-off >> “drive-by” contributions. As such, it was proposed that we consider >> allowing both Gitlab PRs, and email: that for one-off or short series, >> Gitlab PRs would be accepted, but that for longer series and/or longer term >> contributors, we would encourage people to switch to patchbombing the >> mailing list. >> >> We decided to continue the “Gitlab Experiment”, but with short PRs. As >> such, Andy Cooper has posted two PRs: >> >> https://gitlab.com/xen-project/xen/-/merge_requests/2 > > This looks to be confusing, to me at least. Following this link I > can't see the actual change directly. Following either of the links > after "Request to merge" gives a 404 error (after gitlab not being > able to sign me in via Google, but then being able to sign me in > via github) on both > > https://gitlab.com/xen-project/people/andyhhp/xen > https://gitlab.com/xen-project/people/andyhhp/xen/-/tree/xen-pv-segbase
I think you missed on top the “Commits” and “Changes" Just click on changes and you will see the diff or on commit and then you will see the whole thing. > > There's also an endlessly circling kind-of-icon next to "Checking > pipeline status", indicating to me the page tries to load some > information, but can't quite complete doing so. I have the same here. > > I also wonder how one is to become aware of pending merge requests. > For the ones here, your mail was the only indication so far that > they existed. I hope the answer to this is not going to be to poll > gitlab.com. I'm sorry if I'm making newbie mistakes or assumptions > here, but as far as gitlab goes I'm afraid I am. On other gitlab projects (for example Xen-Fusa), i receive mails from gitlab when there is a pull request and i also see a list of pending requests when I go to my the fusa gitlab account. > > As it stands I'm afraid I'll be able to see what is proposed to be > committed (and afaics also approved already) only when it hits the > staging tree. I tried to add a comment and that is working well Remarks from my side: - How can i ack/test/reject on this ? - I found no way to put a “global” comment or to put a comment on the commit message, did I miss something ? Bertrand > > Jan > >> https://gitlab.com/xen-project/xen/-/merge_requests/3 >> >> And I’d encourage others to try submitting simple one-or-two-patch series as >> PRs to Gitlab instead, as we continue the experiment. >> >> -George >> > >
