On 10.08.2020 16:38, Andrew Cooper wrote: > On 07/08/2020 17:33, Andrew Cooper wrote: >> On 07/08/2020 12:32, Jan Beulich wrote: >>> With changes done over time and as far as linking goes, the only special >>> thing about building with EFI support enabled is the need for the dummy >>> relocations object for xen.gz uniformly in all build stages. All other >>> efi/*.o can be consumed from the built_in*.o files. >>> >>> In efi/Makefile, besides moving relocs-dummy.o to "extra", also properly >>> split between obj-y and obj-bin-y. >>> >>> Signed-off-by: Jan Beulich <[email protected]> >> Acked-by: Andrew Cooper <[email protected]> >> >> I'd prefer to see this all in Kconfig, but this is a clear improvement >> in its own right. > > Actually, it breaks the build with LIVEPATCH enabled. > > make[2]: *** No rule to make target 'efi/buildid.o', needed by > '/local/security/xen.git/xen/xen.efi'. Stop. > make[2]: *** Waiting for unfinished jobs.... > Makefile:355: recipe for target '/local/security/xen.git/xen/xen' failed
There must be more to it than just "with LIVEPATCH enabled", as I definitely tested a LIVEPATCH-enabled config. I'll see if I can figure out what's wrong without further details (after my now prolonged "vacation"), but I may need to come back asking for further detail. Jan
