Re: [RFC PATCH V1 05/12] hvm/dm: Introduce xendevicemodel_set_irq_level DM op

[Oleksandr]

On 05.08.20 19:15, Jan Beulich wrote:

Hi, Jan

On 03.08.2020 20:21, Oleksandr Tyshchenko wrote:

--- a/xen/include/public/hvm/dm_op.h
+++ b/xen/include/public/hvm/dm_op.h
@@ -417,6 +417,20 @@ struct xen_dm_op_pin_memory_cacheattr {
      uint32_t pad;
  };

+/*

+ * XEN_DMOP_set_irq_level: Set the logical level of a one of a domain's
+ *                         IRQ lines.
+ * XXX Handle PPIs.
+ */
+#define XEN_DMOP_set_irq_level 19
+
+struct xen_dm_op_set_irq_level {
+    uint32_t irq;
+    /* IN - Level: 0 -> deasserted, 1 -> asserted */
+    uint8_t  level;
+};

If this is the way to go (I've seen other discussion going on),
please make sure you add explicit padding fields and ...

ok

+
+
  struct xen_dm_op {

... you don't add double blank lines.

ok


--
Regards,

Oleksandr Tyshchenko