> -----Original Message----- > From: Anthony PERARD <[email protected]> > Sent: 30 June 2020 16:09 > To: Paul Durrant <[email protected]> > Cc: [email protected]; [email protected]; Eduardo Habkost > <[email protected]>; > Michael S. Tsirkin <[email protected]>; Paul Durrant <[email protected]>; > Jason Andryuk > <[email protected]>; Paolo Bonzini <[email protected]>; Richard Henderson > <[email protected]> > Subject: Re: [PATCH 2/2] xen: cleanup unrealized flash devices > > On Wed, Jun 24, 2020 at 01:18:41PM +0100, Paul Durrant wrote: > > From: Paul Durrant <[email protected]> > > > > The generic pc_machine_initfn() calls pc_system_flash_create() which creates > > 'system.flash0' and 'system.flash1' devices. These devices are then realized > > by pc_system_flash_map() which is called from pc_system_firmware_init() > > which > > itself is called via pc_memory_init(). The latter however is not called when > > xen_enable() is true and hence the following assertion fails: > > > > qemu-system-i386: hw/core/qdev.c:439: qdev_assert_realized_properly: > > Assertion `dev->realized' failed > > > > These flash devices are unneeded when using Xen so this patch avoids the > > assertion by simply removing them using pc_system_flash_cleanup_unused(). > > > > Reported-by: Jason Andryuk <[email protected]> > > Fixes: ebc29e1beab0 ("pc: Support firmware configuration with -blockdev") > > Signed-off-by: Paul Durrant <[email protected]> > > Tested-by: Jason Andryuk <[email protected]> > > Reviewed-by: Anthony PERARD <[email protected]> > > I think I would add: > > Fixes: dfe8c79c4468 ("qdev: Assert onboard devices all get realized properly") > > as this is the first commit where the unrealized flash devices are an > issue.
OK. Paul > > -- > Anthony PERARD
