> -----Original Message----- > From: Andrew Cooper <[email protected]> > Sent: 11 June 2020 18:28 > To: Bertrand Marquis <[email protected]> > Cc: xen-devel <[email protected]>; nd <[email protected]>; Jan > Beulich <[email protected]>; Wei > Liu <[email protected]>; Roger Pau Monné <[email protected]>; Paul Durrant > <[email protected]> > Subject: Re: [PATCH] x86/boot: use BASEDIR for include path > > On 11/06/2020 17:50, Bertrand Marquis wrote: > > Hi Andrew, > > > >> On 11 Jun 2020, at 17:24, Andrew Cooper <[email protected]> wrote: > >> > >> On 11/06/2020 12:54, Bertrand Marquis wrote: > >>> Use $(BASEDIR)/include instead of $(XEN_ROOT)/xen/include for the > >>> include path to be coherent with the rest of the Makefiles. > >>> > >>> Signed-off-by: Bertrand Marquis <[email protected]> > >> Does something subtle break before this change? > > Without changing anything no. > > But if xen sub-directory is renamed yes. > > > > As there is no easy way to build xen hypervisor out of tree (I might be > > wrong here !) I found a > solution using cp -rs from xen subdir in a xen-build1 xen-build2 etc this way > I can check build for > x86 and arm without cleaning. > > > > Without the patch, the sources are actually compiles with an include path > > containing xen/../xen as a > result of using XEN_ROOT which does not allow to rename xen subdirectory. > > As it was the only place in which XEN_ROOT was used for include paths, this > > is normalising the > paths. > > Ok. Acked-by: Andrew Cooper <[email protected]> > > CC Paul for 4.14.
Release-acked-by: Paul Durrant <[email protected]> > > ~Andrew
