Hello,
Jan Beulich, le mer. 13 mai 2020 16:11:00 +0200, a ecrit:
> On 13.05.2020 15:55, Andrew Cooper wrote:
> > Users of EMBEDDED_EXTRA_CFLAGS already use -fno-asynchronous-unwind-tables,
> > or
> > ought to.
>
> It's not really well defined what they're supposed to be used for
> (and where it's not supposed to be used). I notice in particular
> a use in stubdom/Makefile which I'm unsure whether it indeed wants
> this adjustment. Therefore ...
I don't know why this is there in mini-os. It dates back 2005
8afe079be ('Mini-OS cleanups. Bug fixes in x86_64 assembly code.')
It indeed looks to me like a general option to minimize binary size, so
I'd say it is fine to make its activation general.
> > This shrinks the size of the rombios 32bit stubs in guest memory.
> >
> > Signed-off-by: Andrew Cooper <[email protected]>
>
> Reviewed-by: Jan Beulich <[email protected]>
> with the request that Samuel also ack (or otherwise) the change
> from a stubdom perspective.
Samuel
