On 15/04/2020 11:27, Jan Beulich wrote: > On 15.04.2020 03:02, Stefano Stabellini wrote: >> --- a/xen/arch/arm/domain.c >> +++ b/xen/arch/arm/domain.c >> @@ -682,6 +682,7 @@ int arch_domain_create(struct domain *d, >> return 0; >> >> ASSERT(config != NULL); >> + d->arch.direct_map = flags != NULL ? flags->arch.is_direct_map : false; > Shouldn't "true" here imply ->disable_migrate also getting > set to true? Or is this already the case anyway for domains > created right at boot?
Please don't introduce any more uses for disable_migrate. It is fundamentally broken and won't survive to 4.14 (assuming that the 30 odd patches of prereq fixes on xen-devel start unblocking themselves in time) ~Andrew
