On Fri, Dec 27, 2019 at 02:50:58PM +0100, Jan Beulich wrote: > On 27.12.2019 14:45, Andrew Cooper wrote: > > The call to xc_domain_disable_migrate() is made only from x86, while its > > handling in Xen is common. Move it to the libxl__build_pre(). > > > > hvm_set_conf_params(), hvm_set_viridian_features(), > > hvm_set_mca_capabilities(), and the altp2m logic is all in common > > code (parts ifdef'd) but despite this, is all actually x86 specific. > > > > Move it into x86 specific code, and fold all of the xc_hvm_param_set() calls > > together into hvm_set_conf_params() in a far more coherent way. > > > > Finally - ensure that all hypercalls have their return values checked. > > > > No practical change in constructed domains. Fewer useless hypercalls now to > > construct an ARM guest. > > > > Signed-off-by: Andrew Cooper <[email protected]> > > --- > > CC: Ian Jackson <[email protected]> > > CC: Wei Liu <[email protected]> > > CC: Anthony Perard <[email protected]> > > CC: Jan Beulich <[email protected]> > > CC: Wei Liu <[email protected]> > > CC: Roger Pau Monné <[email protected]> > > CC: Stefano Stabellini <[email protected]> > > CC: Julien Grall <[email protected]> > > CC: Volodymyr Babchuk <[email protected]> > > --- > > tools/libxl/libxl_dom.c | 183 > > ++---------------------------------------------- > > tools/libxl/libxl_x86.c | 181 > > ++++++++++++++++++++++++++++++++++++++++++++++- > > I'll defer to the tool stack maintainers here. Imo this file would > better be split - one to contain stuff better falling under x86 > maintainership, and the other for everything falling in the tool > stack realm.
(Assuming you're talking about libxl_x86.c) That works for me. It is unclear to me how clean that split can be though... Wei. > > Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
