On 20/12/2019 13:50, Jan Beulich wrote: > It is wrong for us to check the base address when there's no LDT in the > first place. Once we don't do this check anymore we can also set the > base address to a non-canonical value when the LDT is empty. > > Signed-off-by: Jan Beulich <[email protected]>
I've only just spotted, but this is a semantic change to the guest. Previously, base with ents=0 would be preserved via arch_get_info_guest(). This is likely not interesting from a guests point of view, so is probably fine to change in the ABI. As for the change itself, do you realise that you've not actually relaxed anything? There are checks earlier in arch_set_info_guest() which you haven't altered. Finally, a similar concern about changes which a guest can't actually make use of, even if this one seems rather more minor. ~Andrew _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
