On 12/20/19 2:21 PM, Jan Beulich wrote:
> In ept_p2m_type_to_flags() passing in type and access as separate
> parameters can be considered an optimization, as all callers set the
> respective fields in the entry being updated before the call. Retain
> this behavior but add assertions.
>
> Signed-off-by: Jan Beulich <[email protected]>
In what way is it an optimization?
I don't necessarily oppose this, but given that 3 of the 4 callers
literally do something like:
ept_p2m_type_to_flags(p2m, &e, e.sa_p2mt, e.access);
It seems like just getting rid of the extraneous arguments might a be
better option.
-George
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
