On 11.12.2019 11:58, Hongyan Xia wrote: > @@ -5578,27 +5597,8 @@ int modify_xen_mappings(unsigned long s, unsigned long > e, unsigned int nf) > } > > /* PAGE1GB: shatter the superpage and fall through. */ > - pl2e = alloc_xen_pagetable(); > - if ( !pl2e ) > + if ( shatter_l3e(pl3e, 0, locking) ) > return -ENOMEM;
Hmm, I didn't expect I'd need to comment on this again: As per my v2 reply, you should hand on the return value from the function, not make up your own. This is so that in case the function gains another error path with a different error code, it wouldn't become indistinguishable to callers further up. Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
