On 28.11.19 11:15, Wei Liu wrote:
On Wed, Nov 27, 2019 at 06:24:58PM -0800, Stefano Stabellini wrote:
libxl_arm_acpi.c is using BUILD_BUG_ON but it is not including
xen-tools/libs.h that defines it.
Signed-off-by: Stefano Stabellini <[email protected]>
Acked-by: Wei Liu <[email protected]>
Juergen, this is a trivial patch. I think it can go in 4.13.
Why is this patch needed?
tools/libxl/libxl_arm_acpi.c includes libxl_arm.h, which includes
libxl_internal.h, which includes xen-tools/libs.h.
So this is a purely cosmetic patch, especially as libxl_arm.h and
libxl_internal.h are libxl-internal includes, so there is a very low
risk for the include of xen-tools/libs.h suddenly disappearing, and
even it would due to a patch of one of those include files, it would
be detected by a failing build immediately.
So I won't take it for 4.13, even if being trivial.
Juergen
Wei.
---
tools/libxl/libxl_arm_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c
index ba874c3d32..52c476ff65 100644
--- a/tools/libxl/libxl_arm_acpi.c
+++ b/tools/libxl/libxl_arm_acpi.c
@@ -19,6 +19,7 @@
#include "libxl_arm.h"
#include <stdint.h>
+#include <xen-tools/libs.h>
/* Below typedefs are useful for the headers under acpi/ */
typedef uint8_t u8;
--
2.17.1
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
