Anthony PERARD writes ("[XEN PATCH for-4.13] libxl_pci: Don't hold QMP
connection while waiting"):
> After sending the 'device_del' command for a PCI passthrough device,
> we wait until QEMU has effectively deleted the device, this involves
> executing more QMP commands. While waiting, libxl hold the connection.
I just read the code here. It seems to poll on a timer. How ugly.
> It isn't necessary to hold the connection and it prevents others from
> making progress, so this patch releases the QMP connection.
Right.
> if (rc) goto out;
>
> + libxl__ev_qmp_dispose(gc, qmp);
> +
> asked_id = GCSPRINTF(PCI_PT_QDEV_ID,
It's not it entirely clear to me why you dispose this before the error
exit, but I think it doesn't matter. If it does matter then please
explain :-).
Acked-by: Ian Jackson <[email protected]>
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
