On Tue, Oct 01, 2019 at 12:18:41PM +0200, Christian Lindig wrote: > > > > On 1 Oct 2019, at 11:12, Roger Pau Monne <[email protected]> wrote: > > > > + libxl_asyncop_how *ao_how = aohow_val(async); > > > > caml_enter_blocking_section(); > > - ret = libxl_domain_shutdown(CTX, c_domid); > > + ret = libxl_domain_shutdown(CTX, c_domid, ao_how); > > caml_leave_blocking_section(); > > > > + free(ao_how); > > + > > Does this work when aohow_val returns NULL or does this needs to be checked? > Otherwise This looks good to me.
Both libxl_domain_shutdown and free are perfectly fine to call with ao_how == NULL, but TBH I have no idea of ocaml, so I just copied what's done in stub_libxl_domain_destroy. Thanks, Roger. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
