On Fri, Sep 13, 2019 at 01:10:18PM +0200, Jan Beulich wrote:
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -57,7 +57,6 @@ type domain_create_flag =
> | CDF_OOS_OFF
> | CDF_XS_DOMAIN
> | CDF_IOMMU
> -
Stray deletion?
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -96,9 +96,13 @@ struct xen_sysctl_tbuf_op {
> /* The platform supports software paging. */
> #define _XEN_SYSCTL_PHYSCAP_shadow 4
> #define XEN_SYSCTL_PHYSCAP_shadow (1u<<_XEN_SYSCTL_PHYSCAP_shadow)
> +/* The platform supports sharing of HAP page tables with the IOMMU. */
> +#define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
> +#define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share \
> + (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
I would drop the _hap part of this, since I don't think it adds much,
it's not like the iommu page tables can be shared with anything else?
I don't have a strong opinion, and given that the code already makes
extensive use of iommu_hap_pt_share I would be fine with that.
With the removed newline fixed (if applicable):
Reviewed-by: Roger Pau Monné <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
