On 12/09/2019 09:17, Jan Beulich wrote:
> On 11.09.2019 22:05, Andrew Cooper wrote:
>> @@ -935,6 +935,13 @@ int xc_cpuid_set(
>> goto fail;
>> }
>>
>> + /*
>> + * Notes for following this algorithm:
>> + *
>> + * While it will accept any leaf data, it only makes sense to use on
>> + * feature leaves. regs[] initially contains the host values.
>> This,
>> + * with the fall-through chain is how the 'k' option works.
>> + */
>> for ( j = 0; j < 32; j++ )
>> {
>> unsigned char val = !!((regs[i] & (1U << (31 - j))));
> Looking at the next patch (and hence more closely at the code below
> here) - shouldn't the comment mention both 'k' and 's'?
Hmm. The loop didn't contain any logic looking at == 'k' which is why I
started wondering, but I think you're right - the only use of 's' is for
the feedback to the caller, not for calculation purposes.
I'll adjust the comment suitably.
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
