> -----Original Message----- > From: Jan Beulich <[email protected]> > Sent: 27 August 2019 08:46 > To: Paul Durrant <[email protected]> > Cc: JulienGrall <[email protected]>; Alexandru Isaila > <[email protected]>; Petre Pircalabu > <[email protected]>; Razvan Cojocaru <[email protected]>; > Andrew Cooper > <[email protected]>; George Dunlap <[email protected]>; Ian > Jackson > <[email protected]>; Roger Pau Monne <[email protected]>; > VolodymyrBabchuk > <[email protected]>; Stefano Stabellini <[email protected]>; > xen- > [email protected]; Konrad Rzeszutek Wilk <[email protected]>; > Tamas K Lengyel > <[email protected]>; Tim (Xen.org) <[email protected]>; Wei Liu <[email protected]> > Subject: Re: [Xen-devel] [PATCH 3/6] remove late (on-demand) construction of > IOMMU page tables > > On 12.08.2019 17:41, Paul Durrant wrote: > >> From: Jan Beulich <[email protected]> > >> Sent: 07 August 2019 11:32 > >> > >> On 30.07.2019 15:44, Paul Durrant wrote: > >>> @@ -625,8 +548,7 @@ static void iommu_dump_p2m_table(unsigned char key) > >>> ops = iommu_get_ops(); > >>> for_each_domain(d) > >>> { > >>> - if ( is_hardware_domain(d) || > >>> - dom_iommu(d)->status < IOMMU_STATUS_initialized ) > >>> + if ( !is_iommu_enabled(d) ) > >>> continue; > >> > >> Why do you drop the hwdom check here? > > > > Because is_iommu_enabled() for the h/w domain will always be true if > > iommu_enabled is true, so no need for a special case. > > But the effect of the extra check was to _skip_ Dom0. If you mean to > change this, then you should say so (and why) in the description. >
Ah, yes, it does still need to remain. Paul > Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
