On 8/15/19 5:00 PM, Julien Grall wrote: > Hi George, > > On 15/08/2019 16:48, George Dunlap wrote: >> On 8/15/19 4:36 PM, Julien Grall wrote: >>> Hi George, >>> >>> On 15/08/2019 16:32, George Dunlap wrote: >>>> On 8/15/19 4:29 PM, Julien Grall wrote: >>>>> >>>>> >>>>> On 15/08/2019 16:19, Wieczorkiewicz, Pawel wrote: >>>>>> Hi Lars, Julien, >>>>> >>>>> Hi, >>>>> >>>>>> Thanks for the pointers, I will read them up and follow the >>>>>> recommendations with my future contributions. >>>>>> Sorry for the mess… >>>>>> >>>>>> But, let me ask first before reading the wikis, how do you prefer >>>>>> submitting series that contain patches belonging to 2 distinct repos >>>>>> (e.g. xen and livepatch-build-tools)? >>>>> >>>>> I can see two ways: >>>>> >>>>> 1) One series per project and mention in the cover letter that >>>>> modifications are required in another project (with link/title). >>>>> 2) Combine all the patches in one series and tag them differently. >>>>> I.e >>>>> [XEN] [LIVEPATCH]. >>>>> >>>>> 1) is preferable if you have a lot of patches in each repo. 2) can be >>>>> handy if you have only a couple of patches for one repo. >>>> >>>> 1 is also easier for automated tools (like patchew) to deal with. >>> >>> Out of interest, in general developer will tend to cross-post those >>> patches. So in what way this would make it easier? >> >> If you have two separate series, then patchew will be able to handle one >> and not handle the other. If they're mixed in a single series, patchew >> won't be able to handle it at all. At the moment patchew doesn't do >> anything but give you a nice mbox / git branch to pull; but eventually >> the idea is that it will do some level of testing and give feedback >> (patch does/n't apply, patch does/n't build, patch does/n't pass smoke >> tests / &c). > > Oh, so patchew will try to apply the series. If it does not fully apply, > then it means the series does not target Xen, right?
Either that, or the series needs to be rebased. I rather doubt the patchew authors have spent a lot of time trying to distinguish the two. :-) > I haven't used much patchew so far, but it looks like I should give a > try when committing/reviewing series :). Yes, I've found it quite useful. It automatically adds acks and r-b's as they're given, and also adds the message id into the commit message, which could be useful. One warning: Don't use patchew's branch if you think you might commit a series, because the "committer" is always listed as patchew, rather than yourself. You can see a couple of places in recent history where I've done this, not realizing; but I think it's something we want to avoid. Use the mbox to apply the series instead. -George _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
