On 8/9/19 4:40 PM, Jan Beulich wrote:
> Commit fd35f32b4b ("tools/x86emul: Use struct cpuid_policy in the
> userspace test harnesses") didn't account for the dependencies of
> cpuid-autogen.h to potentially change between incremental builds. In
> particular the harness has a "run" goal which is supposed to be usable
> independently of the rest of the tools sub-tree building, and both the
> harness and the fuzzer code are also supposed to be buildable
> independently. Therefore a re-build of the generated header needs to
> be triggered first, which is achieved by introducing a new top-level
> target pattern (for just the "run" part for now).
>
> Finally cpuid.o did not have any dependencies added for it.
>
> Signed-off-by: Jan Beulich <[email protected]>
> ---
> TBD: Something similar would be nice for building both tools/tests/*/
> and tools/fuzz/*/, but I'm uncertain whether respective top level
> targets build-tests-% and build-fuzz-% would be welcome.
> ---
> v3: Introduce top level run-tests-% target.
> v2.1: Split controversial parts from (hopefully) non-controversial ones.
> v2: Guard $(MAKE) invocations by $(MAKELEVEL) checks.
>
> --- a/Makefile
> +++ b/Makefile
> @@ -80,6 +80,9 @@ build-docs:
> test:
> $(MAKE) -C tools/python test
>
> +run-tests-%: build-tools-public-headers tools/tests/%/
> + $(MAKE) -C tools/tests/$* run
> +
> # For most targets here,
> # make COMPONENT-TARGET
> # is implemented, more or less, by
Hmm -- Thunderbird seems to know that there's only one space here, but
when I save this mail and try to `git am` it, I get hunk failures like this:
```
diff a/Makefile b/Makefile (rejected hunks)
@@ -80,6 +80,9 @@ build-docs:
test:
$(MAKE) -C tools/python test
+run-tests-%: build-tools-public-headers tools/tests/%/
+ $(MAKE) -C tools/tests/$* run
+
# For most targets here,
# make COMPONENT-TARGET
# is implemented, more or less, by
```
Note two spaces before the # rather than 1. I looked at the raw email
and it has two spaces:
```
--- a/Makefile
+++ b/Makefile
@@ -80,6 +80,9 @@ build-docs:
test:
$(MAKE) -C tools/python test
+run-tests-%: build-tools-public-headers tools/tests/%/
+ $(MAKE) -C tools/tests/$* run
+
# For most targets here,
# make COMPONENT-TARGET
# is implemented, more or less, by
```
Oh, weird -- but the version on gmail is a completely different
encoding: gmail has it as encoded base64, whereas my corporate mail has
it encoded as 7-bit. What does everyone else see?
-George
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
