> -----Original Message----- > From: Roger Pau Monne <[email protected]> > Sent: 02 August 2019 10:22 > To: [email protected] > Cc: Roger Pau Monne <[email protected]>; Roman Shaposhnik > <[email protected]>; George Dunlap > <[email protected]>; Jan Beulich <[email protected]>; Andrew Cooper > <[email protected]>; Wei Liu <[email protected]>; Kevin Tian > <[email protected]>; Paul Durrant > <[email protected]> > Subject: [PATCH] x86/iommu: remove usage of {set/clear}_identity_p2m_entry > against PV domains > > Switch rmrr_identity_mapping to use iommu_{un}map in order to > establish RMRR mappings for PV domains, like it's done in > arch_iommu_hwdom_init. This solves the issue of a PV hardware domain > not getting RMRR mappings because {set/clear}_identity_p2m_entry was > not properly updating the iommu page tables. >
I'm not sure this is the right approach. TBH it's not clear to me exactly what role the P2M code should play for a PV domain (I'm guessing it's probably there so that shadowing can be turned on) but it would make more sense to me if fewer paths went round the side of it and the internals handled all of the PV/HVM differences. Paul _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
