On 08.08.2019 02:52, Marek Marczykowski-Górecki wrote:
>> --- a/xen/arch/x86/efi/efi-boot.h
>> +++ b/xen/arch/x86/efi/efi-boot.h
>> @@ -315,8 +315,10 @@ static void __init efi_arch_handle_cmdline(CHAR16
>> *image_name,
>> name.s = "xen";
>> place_string(&mbi.cmdline, name.s);
>>
>> - if ( mbi.cmdline )
>> + if ( mbi.cmdline ) {
>> mbi.flags |= MBI_CMDLINE;
>> + efi_early_parse_cmdline(mbi.cmdline);
>
> Compiler complains here, because mbi.cmdline is u32 (int vs pointer, and
> also a different size). What is the proper way to make compiler happy
> here? "(const char *)(uint64_t)" doesn't seems right.
Well, if the conversion to a pointer is correct here (i.e.
the specified address has a mapping), then
(const char*)(unsigned long) would be the canonical way to
go; using uintptr_t would also be an option, but we make
pretty little use of it.
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel