On 01/08/2019 11:22, Chao Gao wrote: > From: Sergey Dyasli <[email protected]> > > Currently cpu_sig struct is not updated during boot if no microcode blob > is specified by "ucode=[<interger>| scan]". > > It will result in cpu_sig.rev being 0 which affects APIC's > check_deadline_errata() and retpoline_safe() functions. > > Fix this by getting ucode revision early during boot and SMP bring up. > While at it, protect early_microcode_update_cpu() for cases when > microcode_ops is NULL. > > Signed-off-by: Sergey Dyasli <[email protected]> > Signed-off-by: Chao Gao <[email protected]> > --- > Changes in v8: > - refine description. > - Jan asked if we could drop the call of collect_cpu_info() from > microcode_update_cpu(). In theory, yes, but should be placed later > in the series. Because there is an error path (__microcode_fini_cpu()) > in which cpu_sig.rev is cleared, it is hard to make things right > in all cases without removing the error path (which is done by following > patches). Considering it is a good fix, put it here so that it can > be merged without following patches.
Ok. Reviewed-by: Andrew Cooper <[email protected]>, and this does really want backporting. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
