On 16.07.2019 17:06, Roger Pau Monné wrote:
> On Wed, Jul 03, 2019 at 01:04:13PM +0000, Jan Beulich wrote:
>> --- a/tools/misc/xenpm.c
>> +++ b/tools/misc/xenpm.c
>> @@ -64,7 +64,9 @@ void show_help(void)
>> " set-sched-smt enable|disable enable/disable
>> scheduler smt power saving\n"
>> " set-vcpu-migration-delay <num> set scheduler vcpu
>> migration delay in us\n"
>> " get-vcpu-migration-delay get scheduler vcpu
>> migration delay\n"
>> - " set-max-cstate <num>|'unlimited' set the C-State
>> limitation (<num> >= 0)\n"
>> + " set-max-cstate
>> <num>|'unlimited'[,<num2>|'unlimited']\n"
The comma here is wrong, ...
>> @@ -1120,13 +1130,17 @@ void get_vcpu_migration_delay_func(int a
>>
>> void set_max_cstate_func(int argc, char *argv[])
>> {
>> - int value;
>> + int value, subval = XEN_SYSCTL_CX_UNLIMITED;
>> char buf[12];
>>
>> - if ( argc != 1 ||
>> + if ( argc < 1 || argc > 2 ||
>
> I'm quite sure I'm missing something, but shouldn't argc still be 1
> regardless of whether the max sub-state is set or not?
>
> I would expect to scan for something like: "%d,%d" or some such, but
> maybe there's a step I'm missing that splits the string using the ','
> separator?
... misleading you here.
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
