On 05/07/2019 16:31, Jan Beulich wrote:
> --- a/xen/arch/x86/mm/shadow/private.h
> +++ b/xen/arch/x86/mm/shadow/private.h
> @@ -709,11 +709,26 @@ struct sh_emulate_ctxt {
> #endif
> };
>
> +#ifdef CONFIG_HVM
> const struct x86_emulate_ops *shadow_init_emulation(
> struct sh_emulate_ctxt *sh_ctxt, struct cpu_user_regs *regs,
> unsigned int pte_size);
> void shadow_continue_emulation(
> struct sh_emulate_ctxt *sh_ctxt, struct cpu_user_regs *regs);
> +#else
> +static inline const struct x86_emulate_ops *shadow_init_emulation(
> + struct sh_emulate_ctxt *sh_ctxt, struct cpu_user_regs *regs,
> + unsigned int pte_size)
> +{
> + BUG();
> + return NULL;
I'm pretty sure the return NULL is unnecessary, due to the way
unreachable() works inside the BUG.
I'm certain we've got other code which depends on this property to compile.
Either way, Acked-by: Andrew Cooper <[email protected]>
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
