> On Jun 3, 2019, at 1:33 PM, Andrew Cooper <[email protected]> wrote: > > Drop the ap2m_active boolean, and consistently use the unlocking form: > > if ( p2m != hostp2m ) > __put_gfn(p2m, gfn); > __put_gfn(hostp2m, gfn); > > which makes it clear that we always unlock the altp2m's gfn if it is in use, > and always unlock the hostp2m's gfn. This also drops the ternary expression > in the logdirty case. > > Extend the logdirty comment to identify where the locking violation is liable > to occur. > > No (intended) overall change in behaviour. > > Signed-off-by: Andrew Cooper <[email protected]> > Reviewed-by: Razvan Cojocaru <[email protected]> > Reviewed-by: Jan Beulich <[email protected]>
Noticed this when reviewing Tamas’ patch — thanks: Acked-by: George Dunlap <[email protected]> _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
