On 31/05/2019 08:59, Jan Beulich wrote: > >>> +#ifdef CONFIG_HAS_PCI >>> + INIT_LIST_HEAD(&dom_xen->arch.pdev_list); >>> +#endif >> The position of this identifies that we've got obviously got bugs >> (perhaps latent) elsewhere, seeing as other special domains don't get >> working constructs such as list_empty(). >> >> In the code which currently exists, I can't spot it ever being touched >> for ARM, but it is constructed for all non-special x86 guests at the top >> of arch_domain_create(). >> >> I think the best option, given the #ifdef here, is to reposition the >> pdev fields into struct domain, rather than arch_domain, and have this >> code fragment near the top of domain_create() where special domains will >> all be covered. > Except that if I do this, then not by special casing special domains.
What special casing? There is a block of code near the start of domain_create() which is run for all domain, including special ones. ~Andrew _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
