>>> Despite what was said before you're still doing things a 2nd time >>> here just because of hvmemul_send_vm_event()'s needs, even >>> if that function ends up bailing right away. >> >> I don't understand what things are done 2 times. Can you please explain? > > You add code above that exists already in __hvmemul_read(). > Even worse, __hvmemul_read() may not need calling at all, in > which case there's no (emulated) memory access and hence > imo there shouldn't be any event. Plus, just like in the > hvmemul_linear_to_phys() case there may be an exception > raised by the function, yet just like there you also discard the > return value saying so without also zapping the exception. >
Isn't it safer to move the hvmemul_send_vm_event() form hvmemul_insn_fetch() to __hvmemul_read()? Alex _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
