On 22/05/2019 11:18, Jan Beulich wrote: >>>> On 22.05.19 at 12:00, <[email protected]> wrote: >> On 22/05/2019 10:45, Juergen Gross wrote: >>> preempt_count() and the associated per-cpu variable __preempt_count >>> are tested in debug build only. So drop them for non-debug builds. >>> >>> Signed-off-by: Juergen Gross <[email protected]> >> I'd be tempted to fold patches 2 and 3 together, because they are both >> the same change, and it would reduce the churn. >> >> Reviewed-by: Andrew Cooper <[email protected]>, ideally with the >> two folded into one. > I'm a little surprised by this: Wasn't it you who generally > wanted what ASSERT() expands to (controlled by NDEBUG) > be independent of CONFIG_DEBUG, at some point down > the road?
In some ideal world yes, but what is rather more important is actually having optimisation control unrelated to NDEBUG. > Aren't you even having ASSERT()s enabled in > release builds of XenServer, or am I misremembering? If so > patch 3 would move us in the wrong direction. We build and ship a debug and a release hypervisor. ~Andrew _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
