>>> On 16.05.19 at 15:52, <[email protected]> wrote:
> On Wed, May 08, 2019 at 06:48:16AM -0600, Jan Beulich wrote:
>> action->ack_type is set once before the timer even gets initialized, and
>> is never changed later. The timer gets activated only for EOI and UNMASK
>> types. Hence there's no need to have a respective if() in there. Replace
>> it by an ASSERT().
>>
>> Signed-off-by: Jan Beulich <[email protected]>
>
> Reviewed-by: Roger Pau Monné <[email protected]>
Thanks.
>> @@ -1114,19 +1114,18 @@ static void irq_guest_eoi_timer_fn(void
>>
>> action = (irq_guest_action_t *)desc->action;
>>
>> + ASSERT(action->ack_type != ACKTYPE_NONE);
>> +
>> if ( !action->in_flight || timer_is_active(&action->eoi_timer) )
>> goto out;
>>
>> - if ( action->ack_type != ACKTYPE_NONE )
>> + for ( i = 0; i < action->nr_guests; i++ )
>> {
>> - unsigned int i;
>> - for ( i = 0; i < action->nr_guests; i++ )
>> - {
>> - struct domain *d = action->guest[i];
>
> I think you could constify d here.
Ah yes, this should work.
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
