On 5/6/19 7:56 AM, Juergen Gross wrote: > In order to prepare core- and socket-scheduling use a new struct > sched_item instead of struct vcpu for interfaces of the different > schedulers. > > Rename the per-scheduler functions insert_vcpu and remove_vcpu to > insert_item and remove_item to reflect the change of the parameter. > In the schedulers rename local functions switched to sched_item, too. > > For now this new struct will contain a vcpu pointer only and is > allocated on the stack. This will be changed later. > > Signed-off-by: Juergen Gross <[email protected]>
Oy, I realize this comment is going to be somewhat painful, but... 'item' really seems like the wrong word here. To me 'item' always means one thing; whereas what you're planning on doing is grouping together vcpus to schedule together; which would mean "unit" (as in, a military unit). I realize changing it here probably means also changing it in the next 43 patches as well. -George _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
