On 5/6/19 7:56 AM, Juergen Gross wrote:
> Instead of using the SCHED_OP() macro to call the different scheduler
> specific functions add inline wrappers for that purpose.
>
> Signed-off-by: Juergen Gross <[email protected]>
This seems like a great idea. One minor comment...
> +static inline int sched_init(struct scheduler *s)
> +{
> + ASSERT(s->init);
> + return s->init(s);
> +}
> +
> +static inline void sched_deinit(struct scheduler *s)
> +{
> + ASSERT(s->deinit);
> + s->deinit(s);
> +}
I think these would better as BUG_ON()s. These aren't hot paths, and if
we do somehow hit this situation in production, 1) it's safer to
BUG_ON() than dereferencing NULL, and 2) you'll get a more helpful error
message.
Everything else LGTM.
-George
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
