> From: Andrew Cooper [mailto:[email protected]] > Sent: Saturday, February 23, 2019 3:13 AM > > It is unclear why this abstraction exists, but iommu_get_flush() returns > possibly NULL and every user unconditionally dereferences the result. In > practice, I can't spot a path where iommu is NULL, so I think it is mostly > dead. > > Move the two function pointers into struct vtd_iommu (using a flush_ prefix), > and delete iommu_get_flush(). Furthermore, there is no need to pass the > IOMMU > pointer to the callbacks via a void pointer, so change the parameter to be > correctly typed as struct vtd_iommu. Clean up bool_t to bool in surrounding > context. > > Signed-off-by: Andrew Cooper <[email protected]>
Acked-by: Kevin Tian <[email protected]> _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
