> From: Andrew Cooper [mailto:[email protected]]
> Sent: Saturday, February 23, 2019 3:13 AM
> 
> iremap_maddr and qinval_maddr point to the base of a block of contiguous
> RAM,
> allocated by the driver, holding the Interrupt Remapping table, and the
> Queued
> Invalidation ring.
> 
> Despite their name, they are actually the values of the hardware register,
> including control metadata in the lower 12 bits.  While uses of these fields
> do appear to correctly shift out the metadata, this is very subtle behaviour
> and confusing to follow.
> 
> Nothing uses the metadata, so make the fields actually point at the base of
> the relevant tables.
> 
> Signed-off-by: Andrew Cooper <[email protected]>
> Reviewed-by: Jan Beulich <[email protected]>

Good catch!

Acked-by: Kevin Tian <[email protected]>

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to