> From: Roger Pau Monne [mailto:[email protected]]
> Sent: Tuesday, February 19, 2019 1:27 AM
> 
> So that it can be shared by both ept, npt and shadow code, instead of
> duplicating it.
> 
> No change in functionality intended.
> 
> Signed-off-by: Roger Pau Monné <[email protected]>
> Reviewed-by: Paul Durrant <[email protected]>
> Reviewed-by: George Dunlap <[email protected]>

Reviewed-by: Kevin Tian <[email protected]>. with one
small comment:

> +static inline void p2m_entry_modify(struct p2m_domain *p2m,
> p2m_type_t nt,
> +                                    p2m_type_t ot, unsigned int level)
> +{
> +    if ( level != 1 || nt == ot )
> +        return;

based on type check, does it make more sense to call it
p2m_entry_modify_type?

Thanks
Kevin
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to