OK, we'll send a v2 patch soon.
Thank you.
Regards,
Wen
------------------Original Mail------------------
Sender: JuergenGross <[email protected]>
To: wen yang10156314;[email protected]
<[email protected]>[email protected] <[email protected]>
CC: [email protected]
<[email protected]>[email protected]
<[email protected]>zhong weidong10001088;Julia Lawall
<[email protected]>
Date: 2018/11/30 01:01
Subject: Re: [PATCH] pvcalls-front: Use GFP_ATOMIC under spin_lock
On 29/11/2018 13:01, Wen Yang wrote:
> The problem is that we call this with a spin lock held.
> The call tree is:
> pvcalls_front_accept() holds bedata->socket_lock.
> -> create_active()
> -> __get_free_pages() uses GFP_KERNEL
>
> The create_active() function is only called from pvcalls_front_accept()
> with a spin_lock held, The allocation is not allowed to sleep and
> GFP_KERNEL is not sufficient, it has to be ATOMIC.
I'd rather have a function doing the allocations which is called
outside the lock and either passing the allocated data to
create_active() or hook it into map in the allocation function.
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
