On 23/11/2018 14:30, Roger Pau Monne wrote:
LLVM code generation can attempt to load from a variable in the next condition of an expression under certain circumstances, thus turning the following condition: if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) Into: 0xffff82d080223967 <+103>: cmpl $0x3,0x37b032(%rip) # 0xffff82d08059e9a0 <system_state> 0xffff82d08022396e <+110>: setb -0x29(%rbp) 0xffff82d080223972 <+114>: cmpl $0x2,0x228a8b(%rip) # 0xffff82d08044c404 <opt_bootscrub> Such code will trigger a page fault if system_state >= SYS_STATE_active because opt_bootscrub will be unmapped. Fix this by making opt_bootscrub non-init, thus preventing the page fault. The LLVM bug with the discussion about this issue can be found at: https://bugs.llvm.org/show_bug.cgi?id=39707 I haven't been able to find any other instances of such conditional expression that uses system_state together with an init variable or function. Signed-off-by: Roger Pau Monné <[email protected]>
Acked-by: Julien Grall <[email protected]> Cheers,
--- Cc: Andrew Cooper <[email protected]> Cc: George Dunlap <[email protected]> Cc: Ian Jackson <[email protected]> Cc: Jan Beulich <[email protected]> Cc: Julien Grall <[email protected]> Cc: Konrad Rzeszutek Wilk <[email protected]> Cc: Stefano Stabellini <[email protected]> Cc: Tim Deegan <[email protected]> Cc: Wei Liu <[email protected]> Cc: Sergey Dyasli <[email protected]> --- xen/common/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 08ee8cfbb9..56c0b24865 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -166,7 +166,7 @@ enum bootscrub_mode { BOOTSCRUB_ON, BOOTSCRUB_IDLE, }; -static enum bootscrub_mode __initdata opt_bootscrub = BOOTSCRUB_IDLE; +static enum bootscrub_mode opt_bootscrub = BOOTSCRUB_IDLE; static int __init parse_bootscrub_param(const char *s) { /* Interpret 'bootscrub' alone in its positive boolean form */
-- Julien Grall _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
