Hi, Thanks for having a detailed look at it.
> > +#define UART_STATUS_REG 0x0c > > +#define UART_TX_REG 0x00 >> Why ldrh? This is a 32-bit register, actually you can't be sure that the > device supports a 16-bit access. Besides: the bit you are after is in > the upper half, so you actually will never see the bit set. I wonder if > you are loosing characters here. Let me confess with ldrh, I do see output scattered all over the screen and really wondering why the hell I didn't notice it when I sent this RFC. Very sorry about that. > > +.macro early_uart_transmit xb wt > > + strb \wt, [\xb, #UART_TX_REG] > > TX_WFIFO is a 32-bit register, so you should rather use a 32-bit > accessor. Ok.I guess "str" would be OK to use ? Thanks -Amit. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
