Hello Julien, чт, 15 лист. 2018 о 22:20 Julien Grall <[email protected]> пише:
> Well the code suggested is different from what I intended :). t should > be set to invalid before the check mfn_valid/get_page. So this needs at > least 2 checks. 2 places were t != NULL needs to be explained. Well, I guess checking a pointer in order to avoid null pointer dereference is pretty self-explaining. Even if it is done twice. And the code itself would give a clear idea that we do calculate (and assign) type value only in case a caller provided us a valid pointer. For sure, I do not insist on a ternary operator usage. Sincerely, Andrii Anisov. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
