>>> On 12.11.18 at 11:07, <[email protected]> wrote: > On 12/11/2018 09:57, Jan Beulich wrote: >>>>> On 09.11.18 at 15:42, <[email protected]> wrote: >>> No functional change. >> So I understand that "unify" means converting the return type to >> bool. You could have said so. > > Perhaps, but that misses the point of making the change. > > The patch introducing the !CONFIG_HVM version should have used > int/non-const so the API was same, or had this patch as a prerequisite > to update the API to our new standards, and then duplicate it for the > !CONFIG_HVM case.
All fine, just that it would have been nice if the description here said slightly more than just "No functional change." Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
