> -----Original Message----- > From: Jan Beulich [mailto:[email protected]] > Sent: 09 November 2018 10:24 > To: Paul Durrant <[email protected]> > Cc: Andrew Cooper <[email protected]>; xen-devel <xen- > [email protected]> > Subject: Re: [PATCH v3 3/5] viridian: define type for the 'virtual VP > assist page' > > >>> On 07.11.18 at 11:52, <[email protected]> wrote: > > --- a/xen/include/asm-x86/hvm/viridian.h > > +++ b/xen/include/asm-x86/hvm/viridian.h > > @@ -20,11 +20,13 @@ union viridian_page_msr > > } fields; > > }; > > > > +typedef union _HV_VP_ASSIST_PAGE HV_VP_ASSIST_PAGE; > > + > > struct viridian_vcpu > > { > > struct { > > union viridian_page_msr msr; > > - void *va; > > + HV_VP_ASSIST_PAGE *ptr; > > bool pending; > > } vp_assist; > > uint64_t crash_param[5]; > > I'll commit this as is, but even better would have been to avoid > having the typedef here (visible to everyone). >
It goes away in the next patch anyway, when the generalized guest_page is introduced. Paul > Jan > _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
