On 11/05/2018 04:28 PM, Jan Beulich wrote: >>>> On 05.11.18 at 17:17, <[email protected]> wrote: >> On 10/29/2018 03:53 PM, Alexandru Stefan ISAILA wrote: >>> --- a/xen/arch/x86/mm/p2m.c >>> +++ b/xen/arch/x86/mm/p2m.c >>> @@ -448,7 +448,7 @@ mfn_t __get_gfn_type_access(struct p2m_domain *p2m, >>> unsigned long gfn_l, >>> /* Try to unshare. If we fail, communicate ENOMEM without >>> * sleeping. */ >>> if ( mem_sharing_unshare_page(p2m->domain, gfn_l, 0) < 0 ) >>> - (void)mem_sharing_notify_enomem(p2m->domain, gfn_l, 0); >>> + mem_sharing_notify_enomem(p2m->domain, gfn_l, false); >> >> Why do you remove the (void) cast here... >> >>> mfn = p2m->get_entry(p2m, gfn, t, a, q, page_order, NULL); >>> } >>> >>> @@ -839,8 +839,7 @@ guest_physmap_add_entry(struct domain *d, gfn_t gfn, >>> mfn_t mfn, >>> * Foreign domains are okay to place an event as they >>> * won't go to sleep. */ >>> (void)mem_sharing_notify_enomem(p2m->domain, >>> - gfn_x(gfn_add(gfn, i)), >>> - 0); >>> + gfn_x(gfn_add(gfn, i)), >>> false); >> >> ...but not here? > > I had asked that it strictly be removed from lines touched anyway, > and I left it to their discretion to leave alone neighboring lines. Of > course it would have helped if the description said so.
Right. In that case: Acked-by: George Dunlap <[email protected]> _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
