>>> On 22.10.18 at 14:57, <[email protected]> wrote:
> This removes all use of keyhandler_scratch as a bounce-buffer for the rendered
> string. In some cases, collapse combine adjacent printk()'s which are writing
> parts of the same line.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <[email protected]>
> Reviewed-by: Wei Liu <[email protected]>
> Acked-by: Jan Beulich <[email protected]>
> Acked-by: Juergen Gross <[email protected]>
> ---
> CC: Roger Pau Monné <[email protected]>
> CC: Stefano Stabellini <[email protected]>
> CC: Julien Grall <[email protected]>
>
> v2:
> * Use ->bits for cpumasks
No, I'm sorry - this is not what I gave my ack for. I specifically
said that ->bits may only be used by the cpumask implementation.
Everything else should use the cpumask_bits() wrapper.
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1377,11 +1377,9 @@ static void domain_dump_evtchn_info(struct domain *d)
> unsigned int port;
> int irq;
>
> - bitmap_scnlistprintf(keyhandler_scratch, sizeof(keyhandler_scratch),
> - d->poll_mask, d->max_vcpus);
> printk("Event channel information for domain %d:\n"
> - "Polling vCPUs: {%s}\n"
> - " port [p/m/s]\n", d->domain_id, keyhandler_scratch);
> + "Polling vCPUs: {%*pbl}\n"
> + " port [p/m/s]\n", d->domain_id, d->max_vcpus, d->poll_mask);
Neither cpumask_bits() nor its open coding here at all?
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
