Hi Stefano,

On 10/19/18 10:54 PM, Stefano Stabellini wrote:
On Wed, 17 Oct 2018, Julien Grall wrote:
On 17/10/2018 15:42, Stefano Stabellini wrote:
On Mon, 15 Oct 2018, Julien Grall wrote:
Hi Stefano,

On 05/10/2018 19:47, Stefano Stabellini wrote:
It will be #included by a file in a xen/arch/arm subdirectory.

Signed-off-by: Stefano Stabellini <[email protected]>
---
    xen/arch/arm/domain_build.c  |  2 +-
    xen/arch/arm/kernel.c        |  3 +-
    xen/arch/arm/kernel.h        | 86
--------------------------------------------
    xen/include/asm-arm/kernel.h | 86
++++++++++++++++++++++++++++++++++++++++++++

There are way to make git diff nicer for code movement. This seems to be
done
by default on 2.11.0. Not sure for older version. What are you using?

Git version 1.9.1 (and guilt 0.35)

A 4 years old git version. May I ask to update to a new git (or see if there
are an option doing the same)? This would help reviewing code movement.

Unfortunately I get the same with 2.7.4:

  xen/arch/arm/domain_build.c  |  2 +-
  xen/arch/arm/kernel.c        |  3 +-
  xen/arch/arm/kernel.h        | 86 --------------------------------------------
  xen/include/asm-arm/kernel.h | 86 ++++++++++++++++++++++++++++++++++++++++++++
  4 files changed, 88 insertions(+), 89 deletions(-)
  delete mode 100644 xen/arch/arm/kernel.h
  create mode 100644 xen/include/asm-arm/kernel.h

FYI the diff between xen/arch/arm/kernel.h and
xen/include/asm-arm/kernel.h is 0, I don't know why git doesn't pick it
up:

D'oh :/. Probably some configurations in your .config. Thank you for confirming they are both the same.

Cheers,


stefanos@xsjstefanos:/local/repos/xen$ diff xen/arch/arm/kernel.h 
xen/include/asm-arm/kernel.h
stefanos@xsjstefanos:/local/repos/xen$
stefanos@xsjstefanos:/local/repos/xen$ md5sum xen/arch/arm/kernel.h 
xen/include/asm-arm/kernel.h
06bdad45e665f20f03ffdd2822d8f08e  xen/arch/arm/kernel.h
06bdad45e665f20f03ffdd2822d8f08e  xen/include/asm-arm/kernel.h

I hope that helps.


--
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to