On 15/10/18 18:15, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [PATCH] tools/libfsimage: Set soname to 4.12 not
> 0.4.12"):
>> The prevailing style is:
>>
>> MAJOR = 4.12
>> MINOR = 0
>>
>> which is used by all other libraries.
> Err, sorry.
>
> From 3d5d43fa8a23b63ecd5abaf0ffcbddcec8306af2 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <[email protected]>
> To: [email protected]
> Cc: Ian Jackson <[email protected]>
> Cc: Wei Liu <[email protected]>
> Date: Mon, 15 Oct 2018 16:20:26 +0100
> Subject: [PATCH v2] tools/libfsimage: Set soname to 4.12 not 0.4.12
>
> This was set to 0.4.12 by accident in
> c69a6aca8522c7f676953e56191584381adf2c06
> tools/libfsimage: Bump soname to 4.12
>
> The extra 0. is harmless but ugly. We should be somewhat consistent.
>
> Reported-by: Andrew Cooper <[email protected]>
> Signed-off-by: Ian Jackson <[email protected]>
Reviewed-by: Andrew Cooper <[email protected]>
> ---
> v2: Use conventional MAJOR=4.12 MINOR=0
> ---
> tools/libfsimage/common/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libfsimage/common/Makefile
> b/tools/libfsimage/common/Makefile
> index f20e1394a8..b9fb15fcad 100644
> --- a/tools/libfsimage/common/Makefile
> +++ b/tools/libfsimage/common/Makefile
> @@ -1,8 +1,8 @@
> XEN_ROOT = $(CURDIR)/../../..
> include $(XEN_ROOT)/tools/libfsimage/Rules.mk
>
> -MAJOR = 0
> -MINOR = 4.12
> +MAJOR = 4.12
> +MINOR = 0
>
> LDFLAGS-$(CONFIG_SunOS) = -Wl,-M -Wl,mapfile-SunOS
> LDFLAGS-$(CONFIG_Linux) = -Wl,mapfile-GNU
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
