>>> On 08.10.18 at 19:39, <[email protected]> wrote: > On 08/10/18 14:51, Jan Beulich wrote: >>>>> On 05.10.18 at 16:54, <[email protected]> wrote: >>> @@ -405,19 +419,6 @@ struct domain *domain_create(domid_t domid, >>> >>> if ( !is_idle_domain(d) ) >>> { >>> - /* Check d->max_vcpus and allocate d->vcpu[]. */ >>> - err = -EINVAL; >>> - if ( config->max_vcpus < 1 || >>> - config->max_vcpus > domain_max_vcpus(d) ) >>> - goto fail; >> Ah, there it goes away. But I think it would be more logical for this to >> happen in the previous patch. Anyway >> Reviewed-by: Jan Beulich <[email protected]> >> for both, preferably (but not necessarily) with the removal moved >> there. > > The x86 side is trivial, but the ARM side is not. I don't think patches > 3 and 4 should be merged, but I'll let Julien/Stefano have the final say.
I didn't suggest merging the patches, I'd merely like to see the removal above to move into the earlier patch, and the x86 variant of domain_max_vcpus() be dropped there instead of here (because that's where the need for both logically disappears). Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
