> On 27 Sep 2018, at 11:15, Andrew Cooper <[email protected]> wrote: > > On 27/09/18 11:11, Christian Lindig wrote: >> >>> On 27 Sep 2018, at 09:59, Andrew Cooper <[email protected]> wrote: >>> >>> On 27/09/18 08:53, Yang Qian wrote: >>>> 1. Add a common bind virq function >>>> 2. Reduce the stub code of `bind_dom_exc_virq` >>>> >>>> Signed-off-by: Yang Qian <[email protected]> >>> CC'ing the relevant maintainers. >>> >>> Reviewed-by: Andrew Cooper <[email protected]> (forwarding my >>> internal review of this patch) >> There is a discussion about caml_{leave,enter}_blocking_section required for >> this to work in a thread context that is not yet addressed in the patch. > > Right, but that is just a performance issue is it not? We hold the GC > lock longer than we need to. > > i.e. AFACIT, that is a good followup patch, but doesn't invalidate this one? > > ~Andrew
You are correct. It does not invalidate this patch. — Christian _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
