Hi Andrew,
On 09/24/2018 02:00 PM, Andrew Cooper wrote:
The reg[] array can have a maximum size of 8 in practice, so use the worst
case calculation rather than making it variable length.
Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Julien Grall <[email protected]>
Cheers,
---
CC: Stefano Stabellini <[email protected]>
CC: Julien Grall <[email protected]>
Only compile tested.
---
xen/arch/arm/domain_build.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 38e0de3..ac8d479 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -539,9 +539,11 @@ static int __init make_memory_node(const struct domain *d,
int res, i;
int reg_size = addrcells + sizecells;
int nr_cells = reg_size*kinfo->mem.nr_banks;
- __be32 reg[nr_cells];
+ __be32 reg[NR_MEM_BANKS * 4 /* Worst case addrcells + sizecells */];
__be32 *cells;
+ BUG_ON(nr_cells >= ARRAY_SIZE(reg));
+
dt_dprintk("Create memory node (reg size %d, nr cells %d)\n",
reg_size, nr_cells);
--
Julien Grall
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
