> -----Original Message----- > From: Paul Durrant > Sent: 11 September 2018 15:04 > To: 'Jan Beulich' <[email protected]> > Cc: Julien Grall <[email protected]>; Andrew Cooper > <[email protected]>; Wei Liu <[email protected]>; George > Dunlap <[email protected]>; Ian Jackson <[email protected]>; > Stefano Stabellini <[email protected]>; xen-devel <xen- > [email protected]>; Konrad Rzeszutek Wilk > <[email protected]>; Tim (Xen.org) <[email protected]> > Subject: RE: [PATCH v2] tools: add option to explicitly enable VirtFS in QEMU > build > > > -----Original Message----- > > From: Jan Beulich [mailto:[email protected]] > > Sent: 11 September 2018 14:45 > > To: Paul Durrant <[email protected]> > > Cc: Julien Grall <[email protected]>; Andrew Cooper > > <[email protected]>; Wei Liu <[email protected]>; George > > Dunlap <[email protected]>; Ian Jackson > <[email protected]>; > > Stefano Stabellini <[email protected]>; xen-devel <xen- > > [email protected]>; Konrad Rzeszutek Wilk > > <[email protected]>; Tim (Xen.org) <[email protected]> > > Subject: Re: [PATCH v2] tools: add option to explicitly enable VirtFS in > QEMU > > build > > > > >>> On 11.09.18 at 15:37, <[email protected]> wrote: > > > 9pfs support has been a documented feature since Xen 4.9, but QEMU > will > > > not be built with backend support unless VirtFS is enabled, which is > > > predicated on the libcap and libattr dev packages being installed. This is > > > not obvious to anyone intending to use 9pfs. > > > > > > This patch adds an 'enable-9pfs' option to configure which, if specified, > > > will cause '--enable-virtfs' to be passed to QEMU's configure. This will > > > cause the dependency on libcap and libattr to be called out if the > packages > > > are not in installed. > > > > > > For completeness, specifying 'disable-9pfs' will cause '--disable-virtfs' > > > to > > > be passed to QEMU's confgure and not specifying an option will keep the > > > previous behaviour of predicating VirtFS on whether the libcap and libattr > > > packages are installed. > > > > > > NOTE: The shell script in configure might look odd, but it is coded for > > > consistency with other similar logic blocks within the file. > > > > > > Signed-off-by: Paul Durrant <[email protected]> > > > --- > > > Cc: Andrew Cooper <[email protected]> > > > Cc: George Dunlap <[email protected]> > > > Cc: Ian Jackson <[email protected]> > > > Cc: Jan Beulich <[email protected]> > > > Cc: Julien Grall <[email protected]> > > > Cc: Konrad Rzeszutek Wilk <[email protected]> > > > Cc: Stefano Stabellini <[email protected]> > > > Cc: Tim Deegan <[email protected]> > > > Cc: Wei Liu <[email protected]> > > > > > > v2: > > > - Add the configure option rather then enabling VirtFS in all Linux > > > builds. > > > --- > > > config/Tools.mk.in | 1 + > > > tools/Makefile | 10 +++++++++- > > > tools/configure | 29 +++++++++++++++++++++++++++++ > > > 3 files changed, 39 insertions(+), 1 deletion(-) > > > > Wouldn't you first and foremost need to edit tools/configure.ac? > > > > No idea. There seem to be several layer of magic so it's quite believable that > I've missed one. Any clue as to what I need to do there?
OIC... configure is generated despite being checked in... Well that's nice and obvious! Paul > > Paul > > > Jan > > _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
