On 07/09/18 11:24, Olaf Hering wrote: > Am Fri, 7 Sep 2018 09:48:28 +0200 > schrieb Juergen Gross <[email protected]>: > >> On 07/09/18 08:30, Olaf Hering wrote: >>> + if (cpu_online(cpu)) >>> + return; >>> if (cpu_present(cpu)) >>> xen_arch_unregister_cpu(cpu); > >> Could you merge the two if conditions? >> if (!cpu_online(cpu) && cpu_present(cpu)) >> xen_arch_unregister_cpu(cpu); > > Is that any different, beside being wrong, from what the patch actually does?
No. Just a matter of style. > It would still clear the present bit later on. This should be part of the if clause, of course. Juergen _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
